[TS] Fix error with accessorless explicit indices#4484
Closed
coolreader18 wants to merge 3 commits intomasterfrom
Closed
[TS] Fix error with accessorless explicit indices#4484coolreader18 wants to merge 3 commits intomasterfrom
coolreader18 wants to merge 3 commits intomasterfrom
Conversation
coolreader18
requested review from
Shubham8287 and
cloutiertyler
and removed request for
cloutiertyler
Shubham8287
approved these changes
Mar 3, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…less-indices # Conflicts: # crates/bindings-typescript/src/lib/schema.ts # crates/bindings-typescript/src/server/runtime.ts
Collaborator
Author
|
Superseded by #4525 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #4445. We shouldn't have been doing
idx.accessorName!.Expected complexity level and risk
1
Testing